Properly clear dimension filters before disposal.

Merge pull request #127 from sAlexander/master.
square · Sep 24, 2014 · 6e864fc · 6e864fc
2 parents 01b7ec2 + 95f75a2
commit 6e864fc
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 8 deletions.
diff --git a/component.json b/component.json
@@ -2,7 +2,7 @@
   "name": "crossfilter",
   "repo": "square/crossfilter",
   "description": "Fast n-dimensional filtering and grouping of records.",
-  "version": "1.3.6",
+  "version": "1.3.10",
   "keywords": [],
   "main": "crossfilter.js",
   "scripts": [

diff --git a/crossfilter.js b/crossfilter.js
@@ -1,5 +1,5 @@
 (function(exports){
-crossfilter.version = "1.3.9";
+crossfilter.version = "1.3.10";
 function crossfilter_identity(d) {
   return d;
 }
@@ -1245,9 +1245,8 @@ function crossfilter() {
       if (i >= 0) dataListeners.splice(i, 1);
       i = removeDataListeners.indexOf(removeData);
       if (i >= 0) removeDataListeners.splice(i, 1);
-      for (i = 0; i < n; ++i) filters[i] &= zero;
       m &= zero;
-      return dimension;
+      return filterAll();
     }
 
     return dimension;

diff --git a/crossfilter.min.js b/crossfilter.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "crossfilter",
-  "version": "1.3.9",
+  "version": "1.3.10",
   "description": "Fast multidimensional filtering for coordinated views.",
   "keywords": [
     "square",