Data scope: complete, consistent, and tested (#4)

aws/rds_test.go

@@ -0,0 +1,21 @@
+// Copyright 2024 Block, Inc.
+
+package aws
+
+import (
+	"testing"
+)
+
+func TestRDSCert(t *testing.T) {
+	var err any
+	f := func() {
+		defer func() {
+			err = recover()
+		}()
+		RegisterRDSCA() // panics on any error
+	}
+	f()
+	if err != nil {
+		t.Errorf("RegisterRDSCA paniced: %v", err)
+	}
+}

benchmarks/intro/read-only.yaml

@@ -1,3 +1,5 @@
+# https://square.github.io/finch/benchmark/examples/#intro
+
 stage:
   runtime: 10s
   workload:

benchmarks/intro/row-lock.yaml

@@ -1,3 +1,5 @@
+# https://square.github.io/finch/benchmark/examples/#intro
+
 stage:
   runtime: 20s
   workload:

benchmarks/intro/schema.sql

@@ -0,0 +1,6 @@
+CREATE TABLE t1 (
+  id INT UNSIGNED NOT NULL PRIMARY KEY,
+  n  INT NOT NULL,
+  c  VARCHAR(100) NOT NULL,
+  INDEX (n)
+)

benchmarks/intro/setup.yaml

@@ -1,5 +1,8 @@
+# https://square.github.io/finch/benchmark/examples/#intro
+
 stage:
   trx:
+    - file: schema.sql
     - file: insert-rows.sql
       data:
         id:

benchmarks/jcole-bug-97001/after.yaml

@@ -0,0 +1,17 @@
+# https://bugs.mysql.com/bug.php?id=97001
+# https://blog.jcole.us/2019/09/30/reconsidering-access-paths-for-index-ordering-a-dangerous-optimization-and-a-fix/
+# https://hackmysql.com/post/infamous-order-by-limit-query-optimizer-bug/
+
+stage:
+  trx:
+    - file: shift-rows.sql # UPDATE t SET id=id+1000000 WHERE other_id = 555
+    - file: get-1-row.sql
+  workload:
+    - group: shift
+      trx: [shift-rows.sql]
+      iter: 1
+      disable-stats: true
+
+    - group: after
+      trx: [get-1-row.sql]
+      iter: 2

benchmarks/jcole-bug-97001/before.yaml

@@ -0,0 +1,9 @@
+# https://bugs.mysql.com/bug.php?id=97001
+# https://blog.jcole.us/2019/09/30/reconsidering-access-paths-for-index-ordering-a-dangerous-optimization-and-a-fix/
+# https://hackmysql.com/post/infamous-order-by-limit-query-optimizer-bug/
+
+stage:
+  trx:
+    - file: get-1-row.sql
+  workload:
+    - iter: 1000

benchmarks/jcole-bug-97001/get-1-row.sql

@@ -0,0 +1 @@
+SELECT non_covered_column FROM t WHERE other_id = 555 ORDER BY id ASC LIMIT 1

benchmarks/jcole-bug-97001/insert-rows.sql

@@ -0,0 +1,2 @@
+-- prepare
+INSERT INTO t (id, other_id, covered_column, non_covered_column) VALUES /*!csv 5000 (@n(), @n % 1000, @n, @n)*/

benchmarks/jcole-bug-97001/schema.sql

@@ -0,0 +1,8 @@
+CREATE TABLE t (
+  id                  BIGINT        NOT NULL,
+  other_id            BIGINT        NOT NULL,
+  covered_column      VARCHAR(50)   NOT NULL,
+  non_covered_column  VARCHAR(50)   NOT NULL,
+  PRIMARY KEY (id),
+  INDEX index_other_id_covered_column (other_id, covered_column)
+)

benchmarks/jcole-bug-97001/setup.yaml

@@ -0,0 +1,17 @@
+# https://bugs.mysql.com/bug.php?id=97001
+# https://blog.jcole.us/2019/09/30/reconsidering-access-paths-for-index-ordering-a-dangerous-optimization-and-a-fix/
+# https://hackmysql.com/post/infamous-order-by-limit-query-optimizer-bug/
+
+stage:
+  trx:
+    - file: schema.sql
+    - file: insert-rows.sql
+      data:
+        n:
+          generator: auto-inc
+          scope: client-group
+  workload:
+    - trx: [schema.sql]
+    - trx: [insert-rows.sql] # 5k rows/insert 
+      iter-clients: 200      # x 200 inserts = 1,000,000 rows
+      clients: 4

benchmarks/jcole-bug-97001/shift-rows.sql

@@ -0,0 +1 @@
+UPDATE t SET id=id+1000000 WHERE other_id = 555

benchmarks/sysbench/read-only.yaml

@@ -10,13 +10,11 @@ stage:
       data:
         id:
           generator: "int"
-          scope: client
           params:
             max: $params.rows
             dist: normal
         id_100:
           generator: "int-range"
-          scope: client
           params:
             range: 100
             max: $params.rows

benchmarks/sysbench/trx/read-only.sql

@@ -17,4 +17,5 @@ SELECT c FROM sbtest1 WHERE id BETWEEN @id_100 AND @PREV ORDER BY c
 -- prepare
 SELECT DISTINCT c FROM sbtest1 WHERE id BETWEEN @id_100 AND @PREV ORDER BY c
 
+-- prepare
 COMMIT

benchmarks/xfer/_all.yaml

@@ -1,3 +1,4 @@
+# https://square.github.io/finch/benchmark/examples/#xfer
 
 params:
   customers: 1,000,000 # + 3 balances per customer (4M rows total)

benchmarks/xfer/setup.yaml

@@ -1,16 +1,18 @@
+# https://square.github.io/finch/benchmark/examples/#xfer
+
 stage:
   name: setup
   stats:
     disable: true
   workload:
     - clients: 1                  #
-      name: schema                # exec group "schema"
+      group: schema               # exec group "schema"
       trx: [schema.sql]           #
     - clients: 2                    #
-      name: rows                    #
+      group: rows                   #
       trx: [insert-cust-bal.sql]    # exec group "rows"
     - clients: 2                    #
-      name: rows                    #
+      group: rows                   #
       trx: [insert-xfers.sql]       #
 
   trx:

benchmarks/xfer/xfer.yaml

@@ -1,3 +1,4 @@
+# https://square.github.io/finch/benchmark/examples/#xfer
 
 stage:
   name: xfer