This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Improve multi-recipient/multi-sig handling #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csstaub
force-pushed
the
cs/better-multi
branch
from
4ab2177
to
b303cc6
Compare
| } | ||
|
|
||
| // The "zip" header parameter may only be present in the protected header. | ||
| if obj.protected.Zip != "" { | ||
| plaintext, err = decompress(obj.protected.Zip, plaintext) | ||
| } | ||
|
|
||
| return plaintext, err | ||
| return index, headers.sanitized(), plaintext, err |
There was a problem hiding this comment.
It might be cleaner to not return index, headers and plaintext if err is set here.
There was a problem hiding this comment.
Code here will not execute if decryption failed (will return on the plaintext is nil check above).
| } | ||
|
|
||
| if i != 1 { | ||
| t.Fatal("recipient index should be 0 for RSA key") |
alokmenghrajani
approved these changes
Sep 22, 2016
csstaub
force-pushed
the
cs/better-multi
branch
from
b303cc6
to
350b341
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to multi-recipient/multi-sig handling.
DecryptandVerify.VerifyMultiandDecryptMultifunctions for old use-cases.The new
VerifyMultiandDecryptMultifunctions will return the index of the recipient/signature that has been verified, along with the header or signature object. This ensures that callers don't accidentally verify one signature but then read headers from another, as the oldVerifyorDecryptdidn't say which recipient/signature ended up being valid.Because this is a subtle API change, it will likely be released as
v1.1.0once merged into thev1branch. I'm not aware of any public projects using this library that depend on multi-sig so I think it's acceptable to still call thisv1.