fix!: renames global 'variants' to 'patterns' to avoid name collision with local 'variant' props #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with local 'variant' props
|
Styleguide deployed to https://square.github.io/maker/styleguide/patterns/#/ |
📊 Package size report 0.08%↑
Unchanged files
Hidden files
🤖 This report was automatically generated by pkg-size-action |
laurenhu
approved these changes
Apr 12, 2022
|
🎉 This PR is included in version 10.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
pretzelhammer
added a commit
that referenced
this pull request
May 11, 2022
* feat!: user-defined theme variants for mtext & mbutton (#278) * feat(text)!: theme variants * refactor(heading)!: removes heading component after merging it into text component * refactor!: changes mtext theme defaults & theme prop resolution algo * docs(text): variant docs * feat(button)!: user defined theme variants * docs: fix headings in beta advanced lab demo (#284) * fix!: typography defaults (#285) * fix!: typography defaults * docs: theme lab typo controls (#286) * docs: adds basic typography controls to ThemeTest lab * docs: adds typography variants controls to ThemeTest lab * docs: moves typography controls to top of themetest lab * fix(theme): 0 values now resolve correctly (#287) * fix!: renames global 'variants' to 'patterns' to avoid name collision with local 'variant' props (#293) * feat!: theme font family weight internally (#289) * feat(input): theme input component text style * feat(textarea): themes textarea text style * feat(actionbarbutton): themes actionbarbutton's text style * feat(button): themes button text style * feat(calendar): themes calendar text styles * feat(choice): themes Choice text style * feat(container): themes container's label & content text styles * docs: more spacing in ThemeTest lab * feat(notice): themes notice's text content * feat(pininput): themes pininput text content * feat: themes SegmentedControl & Select text content * feat(stepper): themes stepper text content * feat(textbutton): themes textbutton's text content * feat: themes labels & sublabels in inline form controls * fix(container): fixes which global text styles are applied to container * docs: adds title family & weight to ThemeTest lab * feat: themes text content in Blades, Dialogs, Modals * fix: headlines have same font family as titles * fix: themed colors for Calendar, Container, & Inline Form components * refactor!: renames heading & body colors to title & paragraph * fix: title & paragraph color theming * fix: label default theme * feat: more typography css inheritance * docs: updates ThemeTest docs & Text docs * refactor: minimizes paragraph css in calendar * refactor: minimizes css styles in container * refactor: minimizes typo css in modal, dialog, blade * refactor: minimizes typo css in input * refactor: minimizes typo css in notice * refactor: minimizes typo css in select * refactor: minimizes typo css in inline form controls * docs: updates variants to patterns * refactor!: prefix public css vars (#305) * refactor!: prefix public css vars * docs: update themes lab to use public css var * refactor!: removes unnecessary color prefix on vars (#307) * refactor!: some font-related config renames (#311) * refactor!: renames font-related color, family, & weight vars * docs(theme): updates after font-related var renames * docs(themetest): updates themetest lab after font-related var renames * docs: adds table of reusable theme vars to theme docs * refactor!: rename css vars again * docs: update themes lab colors theme object * docs: more Themes lab fixes * docs: finally fixes Themes lab
pretzelhammer
added a commit
that referenced
this pull request
May 11, 2022
…vars (#320) * feat!: user-defined theme variants for mtext & mbutton (#278) * feat(text)!: theme variants * refactor(heading)!: removes heading component after merging it into text component * refactor!: changes mtext theme defaults & theme prop resolution algo * docs(text): variant docs * feat(button)!: user defined theme variants * docs: fix headings in beta advanced lab demo (#284) * fix!: typography defaults (#285) * fix!: typography defaults * docs: theme lab typo controls (#286) * docs: adds basic typography controls to ThemeTest lab * docs: adds typography variants controls to ThemeTest lab * docs: moves typography controls to top of themetest lab * fix(theme): 0 values now resolve correctly (#287) * fix!: renames global 'variants' to 'patterns' to avoid name collision with local 'variant' props (#293) * feat!: theme font family weight internally (#289) * feat(input): theme input component text style * feat(textarea): themes textarea text style * feat(actionbarbutton): themes actionbarbutton's text style * feat(button): themes button text style * feat(calendar): themes calendar text styles * feat(choice): themes Choice text style * feat(container): themes container's label & content text styles * docs: more spacing in ThemeTest lab * feat(notice): themes notice's text content * feat(pininput): themes pininput text content * feat: themes SegmentedControl & Select text content * feat(stepper): themes stepper text content * feat(textbutton): themes textbutton's text content * feat: themes labels & sublabels in inline form controls * fix(container): fixes which global text styles are applied to container * docs: adds title family & weight to ThemeTest lab * feat: themes text content in Blades, Dialogs, Modals * fix: headlines have same font family as titles * fix: themed colors for Calendar, Container, & Inline Form components * refactor!: renames heading & body colors to title & paragraph * fix: title & paragraph color theming * fix: label default theme * feat: more typography css inheritance * docs: updates ThemeTest docs & Text docs * refactor: minimizes paragraph css in calendar * refactor: minimizes css styles in container * refactor: minimizes typo css in modal, dialog, blade * refactor: minimizes typo css in input * refactor: minimizes typo css in notice * refactor: minimizes typo css in select * refactor: minimizes typo css in inline form controls * docs: updates variants to patterns * refactor!: prefix public css vars (#305) * refactor!: prefix public css vars * docs: update themes lab to use public css var * refactor!: removes unnecessary color prefix on vars (#307) * refactor!: some font-related config renames (#311) * refactor!: renames font-related color, family, & weight vars * docs(theme): updates after font-related var renames * docs(themetest): updates themetest lab after font-related var renames * docs: adds table of reusable theme vars to theme docs * refactor!: rename css vars again * docs: update themes lab colors theme object * docs: more Themes lab fixes * docs: finally fixes Themes lab
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem this PR addresses
allows customizing existing "patterns" and creating new "patterns" for buttons, which was not possible previously while they were still called "variants" and there was a name collision with button's local "variant" prop
Describe the changes in this PR
just did
Migration Guide
<m-text variant="etc">to<m-text pattern="etc"><m-button variant="etc">to<m-button pattern="etc">