Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: changes stacked modals transition #34

Closed

Conversation

pretzelhammer
Copy link
Collaborator

Describe the problem prior to this PR (link ticket/issue):
"jumpy" modals

Describe the changes in this PR:

makes stacked modals transition smoother

Other information:
no

@github-actions
Copy link

github-actions bot commented Mar 11, 2021

📊 Package size report   0.4%↑

File Before After
/components/Modal/script.js 7.2 kB 9%↑7.9 kB
/components/Modal/styles.css 925 B -19.7%↓743 B
Total (Includes all files) 809.6 kB 0.4%↑812.9 kB
Tarball size 133.3 kB 0.8%↑134.4 kB
Unchanged files
File Size
/components/ActionBar/index.js 50 B
/components/ActionBar/script.js 14.4 kB
/components/ActionBar/styles.css 3.7 kB
/components/Button/index.js 50 B
/components/Button/script.js 5.2 kB
/components/Button/styles.css 2.6 kB
/components/Checkbox/index.js 50 B
/components/Checkbox/script.js 4.3 kB
/components/Checkbox/styles.css 1.5 kB
/components/Divider/index.js 50 B
/components/Divider/script.js 2.4 kB
/components/Divider/styles.css 96 B
/components/Heading/index.js 50 B
/components/Heading/script.js 3.1 kB
/components/Heading/styles.css 2.8 kB
/components/Image/index.js 50 B
/components/Image/script.js 3.9 kB
/components/Image/styles.css 142 B
/components/Input/index.js 50 B
/components/Input/script.js 4.6 kB
/components/Input/styles.css 2.7 kB
/components/Loading/index.js 50 B
/components/Loading/script.js 2.9 kB
/components/Loading/styles.css 973 B
/components/Modal/index.js 50 B
/components/Notice/index.js 50 B
/components/Notice/script.js 4.0 kB
/components/Notice/styles.css 587 B
/components/Radio/index.js 50 B
/components/Radio/script.js 4.0 kB
/components/Radio/styles.css 1.4 kB
/components/Section/index.js 50 B
/components/Section/script.js 3.1 kB
/components/Section/styles.css 836 B
/components/SegmentedControl/index.js 50 B
/components/SegmentedControl/script.js 3.9 kB
/components/SegmentedControl/styles.css 667 B
/components/Select/index.js 50 B
/components/Select/script.js 5.1 kB
/components/Select/styles.css 1.6 kB
/components/Skeleton/index.js 50 B
/components/Skeleton/script.js 5.1 kB
/components/Skeleton/styles.css 625 B
/components/Stepper/index.js 50 B
/components/Stepper/script.js 4.2 kB
/components/Stepper/styles.css 335 B
/components/Text/index.js 50 B
/components/Text/script.js 2.8 kB
/components/Text/styles.css 907 B
/components/Textarea/index.js 50 B
/components/Textarea/script.js 4.1 kB
/components/Textarea/styles.css 2.0 kB
/components/Theme/index.js 28 B
/components/Theme/script.js 8.0 kB
/components/Toggle/index.js 50 B
/components/Toggle/script.js 4.3 kB
/components/Toggle/styles.css 3.1 kB
/components/TransitionFade/index.js 28 B
/components/TransitionFade/script.js 2.8 kB
/components/TransitionResize/index.js 28 B
/components/TransitionResize/script.js 3.9 kB
/components/TransitionSpringUp/index.js 28 B
/components/TransitionSpringUp/script.js 2.8 kB
/LICENSE 552 B
/package.json 4.5 kB
/README.md 327 B
/utils/assert.js 1.5 kB
/utils/BlockFormControlLayout/index.js 50 B
/utils/BlockFormControlLayout/script.js 2.5 kB
/utils/BlockFormControlLayout/styles.css 267 B
/utils/InlineFormControlLayout/index.js 50 B
/utils/InlineFormControlLayout/script.js 2.9 kB
/utils/InlineFormControlLayout/styles.css 332 B
/utils/TransitionSpring/index.js 28 B
/utils/TransitionSpring/script.js 2.9 kB
/utils/TransitionSpringResponsive/index.js 28 B
/utils/TransitionSpringResponsive/script.js 3.1 kB
Hidden files
File Before After
/components/ActionBar/script.js.map 73.2 kB 73.2 kB
/components/ActionBar/styles.css.map 14.4 kB 14.4 kB
/components/Button/script.js.map 23.3 kB 23.3 kB
/components/Button/styles.css.map 8.5 kB 8.5 kB
/components/Checkbox/script.js.map 21.1 kB 21.1 kB
/components/Checkbox/styles.css.map 4.1 kB 4.1 kB
/components/Divider/script.js.map 13.0 kB 13.0 kB
/components/Divider/styles.css.map 691 B 691 B
/components/Heading/script.js.map 17.0 kB 17.0 kB
/components/Heading/styles.css.map 5.3 kB 5.3 kB
/components/Image/script.js.map 16.8 kB 16.8 kB
/components/Image/styles.css.map 2.8 kB 2.8 kB
/components/Input/script.js.map 23.7 kB 23.7 kB
/components/Input/styles.css.map 6.4 kB 6.4 kB
/components/Loading/script.js.map 15.1 kB 15.1 kB
/components/Loading/styles.css.map 2.3 kB 2.3 kB
/components/Modal/script.js.map 28.2 kB 6%↑29.7 kB
/components/Modal/styles.css.map 4.8 kB 26%↑6.1 kB
/components/Notice/script.js.map 17.7 kB 17.7 kB
/components/Notice/styles.css.map 2.9 kB 2.9 kB
/components/Radio/script.js.map 19.8 kB 19.8 kB
/components/Radio/styles.css.map 3.8 kB 3.8 kB
/components/Section/script.js.map 16.2 kB 16.2 kB
/components/Section/styles.css.map 2.8 kB 2.8 kB
/components/SegmentedControl/script.js.map 19.5 kB 19.5 kB
/components/SegmentedControl/styles.css.map 3.3 kB 3.3 kB
/components/Select/script.js.map 23.6 kB 23.6 kB
/components/Select/styles.css.map 5.4 kB 5.4 kB
/components/Skeleton/script.js.map 21.9 kB 21.9 kB
/components/Skeleton/styles.css.map 2.9 kB 2.9 kB
/components/Stepper/script.js.map 18.1 kB 18.1 kB
/components/Stepper/styles.css.map 3.3 kB 3.3 kB
/components/Text/script.js.map 14.3 kB 14.3 kB
/components/Text/styles.css.map 2.6 kB 2.6 kB
/components/Textarea/script.js.map 21.1 kB 21.1 kB
/components/Textarea/styles.css.map 4.9 kB 4.9 kB
/components/Theme/script.js.map 40.7 kB 40.7 kB
/components/Toggle/script.js.map 22.3 kB 22.3 kB
/components/Toggle/styles.css.map 5.6 kB 5.6 kB
/components/TransitionFade/script.js.map 12.4 kB 12.4 kB
/components/TransitionResize/script.js.map 16.2 kB 16.2 kB
/components/TransitionSpringUp/script.js.map 12.5 kB 12.5 kB
/utils/assert.js.map 6.1 kB 6.1 kB
/utils/BlockFormControlLayout/script.js.map 12.3 kB 12.3 kB
/utils/BlockFormControlLayout/styles.css.map 896 B 896 B
/utils/InlineFormControlLayout/script.js.map 14.7 kB 14.7 kB
/utils/InlineFormControlLayout/styles.css.map 1.3 kB 1.3 kB
/utils/TransitionSpring/script.js.map 12.6 kB 12.6 kB
/utils/TransitionSpringResponsive/script.js.map 13.6 kB 13.6 kB

🤖 This report was automatically generated by pkg-size-action

@github-actions
Copy link

@pretzelhammer
Copy link
Collaborator Author

closing this as it's made obsolete by this #35

@pretzelhammer pretzelhammer deleted the desktop-modal-stacking-slide-transitions branch March 15, 2021 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant