Added support for weak imports in ProtoParser, ProtoFile and ProtoFileElement #3227
+21
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test, but otherwise looks fine. |
paul35621
changed the title
|
I can't push to this branch but I've modified an existing test here: https://github.com/square/wire/compare/bquenaudon.2025-01-06.weakimports?expand=1 |
|
Alright, great! Should I integrate that in this pull request, or what would be the next step? |
|
Yes, please add a test to this PR so we can validate that it and the others pass with the new changes. |
|
@JakeWharton Can you edit this pull request or make a new one? The code with the test is already on the bquenaudon.2025-01-06.weakimports branch. I've tried to figure out how to make a pull request, but it's above my head. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed
ProtoParser,ProtoFileandProtoFileElementto support weak imports.I didn't try to compile this, but if it does compile then the new behaviour would be that weak imports are ignored, since I added a field
weakImportstoProtoFileandProtoFileElementthat is not read outside of these classes. The current situation is that parsing fails when the file contains a weak import, so I consider that an improvement.See issue 3226.