This repository has been archived by the owner on Feb 5, 2021. It is now read-only.
Upgrade Compose to dev11. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/dev11
branch
from
82171b3 to
1e34b3c
Compare
Input to legacy views hosted inside a composition seems to (partially) work now! The positions are a little off, but you can see buttons being clicked. There's a bug in our subcomposition infra that causes infinite rerenders, and prevents updates from actually showing up in legacy views, but I'll fix that in a follow- up.
zach-klippenstein
force-pushed
the
zachklipp/dev11
branch
from
1e34b3c to
84fa590
Compare
rjrjr
approved these changes
May 18, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input to legacy views hosted inside a composition seems to (partially) work now!
The positions are a little off, but you can see buttons being clicked. There's
a bug in our subcomposition infra that causes infinite rerenders, and prevents
updates from actually showing up in legacy views, but I'll fix that in a follow-
up.