Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

reimplementation of heldout-test evaluation structure #302

Open
wants to merge 5 commits into
base: mpt_dj
Choose a base branch
from

Conversation

pdreiter
Copy link
Collaborator

@pdreiter pdreiter commented Apr 7, 2023

based on @ChrisTimperley 's feedback issue #300

  • Enables a new CLI interface (darjeeling evaluate)
  • tested, but seeing some issues with test timeouts (Currently, ResourceUsageTracker(limits=None), so I may need to add back in this from the configuration)

…Timperley's feedback issue #300

- tested, but seeing some issues with test timeouts
@pdreiter pdreiter requested a review from ChrisTimperley April 7, 2023 16:00
@pdreiter pdreiter marked this pull request as draft April 7, 2023 16:00
@pdreiter
Copy link
Collaborator Author

pdreiter commented Apr 7, 2023

@ChrisTimperley - just finished additional testing, 'tis working nicely. I will push the butrs changes so you can check it out.

@pdreiter pdreiter marked this pull request as ready for review April 7, 2023 22:03
@pdreiter
Copy link
Collaborator Author

pdreiter commented Apr 8, 2023

@ChrisTimperley - errors/warnings identified by tox have been cleaned up and repair functionality looks good. assess passes, so you're free to review the changeset.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants