Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Mermaid to 11.* #7475

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Update Mermaid to 11.* #7475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...assets/javascripts/bundle.af256bd8.min.js → ...assets/javascripts/bundle.da20803e.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions ...ts/javascripts/bundle.af256bd8.min.js.map → ...ts/javascripts/bundle.da20803e.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion material/templates/assets/stylesheets/main.35f28582.min.css.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion material/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@
</script>
{% endblock %}
{% block scripts %}
<script src="{{ 'assets/javascripts/bundle.af256bd8.min.js' | url }}"></script>
<script src="{{ 'assets/javascripts/bundle.da20803e.min.js' | url }}"></script>
{% for script in config.extra_javascript %}
{{ script | script_tag }}
{% endfor %}
Expand Down
2 changes: 1 addition & 1 deletion src/templates/assets/javascripts/components/content/mermaid/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ marker {

/* Flowchart edge label */
.edgeLabel,
.edgeLabel rect {
.edgeLabel p {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change in order for the edge labels in this flowchart to have their background look the same as the diagram backgroud (in both dark and light modes). I know little about CSS and HTML - I'm not sure if this change breaks anything outside of my limited testing.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we might need this change, or edge labels are not readable in dark mode. It looks like they changed the rect to p, so this change should be okay. We'll find out as we go whether we need more changes.

color: var(--md-mermaid-edge-color);
background-color: var(--md-mermaid-label-bg-color);
fill: var(--md-mermaid-label-bg-color);
Expand Down
2 changes: 1 addition & 1 deletion src/templates/assets/javascripts/components/content/mermaid/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ let sequence = 0
*/
function fetchScripts(): Observable<void> {
return typeof mermaid === "undefined" || mermaid instanceof Element
? watchScript("https://unpkg.com/mermaid@10/dist/mermaid.min.js")
? watchScript("https://unpkg.com/mermaid@11/dist/mermaid.min.js")
: of(undefined)
}

Expand Down