Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix file save regression in privacy plugin #7673

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

nejch
Copy link
Contributor

@nejch nejch commented Nov 5, 2024

Closes #7672

The reproduction repo is provided in #7672.

@nejch nejch mentioned this pull request Nov 5, 2024
4 tasks
@nejch nejch marked this pull request as ready for review November 5, 2024 16:04
@@ -467,7 +467,7 @@ def _patch(self, initiator: File):

# Replace callback
def replace(match: Match):
value = match.group(1)
value = match.group("url")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the issue was that replace was called on the self.assets_expr_map[extension] entry in the parent method, which we've changed so positional groups didn't always give reliable results.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for investigating and fixing!

@@ -467,7 +467,7 @@ def _patch(self, initiator: File):

# Replace callback
def replace(match: Match):
value = match.group(1)
value = match.group("url")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for investigating and fixing!

@squidfunk squidfunk merged commit eb63b60 into squidfunk:master Nov 5, 2024
4 checks passed
@nejch nejch deleted the fix/named-group-replace branch November 5, 2024 18:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy plugin causes a 404 on css
2 participants