Non-standard exit codes in phpcbf makes it hard to integrate it

[esamattis]

Hi!

I tried to integrate phpcbf to neoformat (issue 54) but that seems to be impossible without a wrapper script because phpcbf returns a non-zero exit status on success. In POSIX systems exit status should be zero always when the program executed as it was suposed to. More info http://stackoverflow.com/questions/1101957/are-there-any-standard-exit-status-codes-in-linux

I'd recommend that the non-standard exit codes introduced in #1270 would be moved under a flag (or just removed).

[gsherwood]

PHPCBF has several exit states and so has several exit codes. You'll need to check the exit code and decide if the script exited the way you expected because I'm not changing the current codes. They've been there in PHPCS and PHPCBF for years and checking the return value of a script is pretty easy.

[esamattis]

Fair enough. I do appreciate preserving backwards compatibility. I though this was a new thing in 3.0.0RC3.

[deleugpn]

Just in case anybody else lands on this issue, the command #1818 (comment) is very helpful to start making your own workaround