Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for diacritics in camel caps names #3532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julienfalque
Copy link

No description provided.

Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienfalque Sorry it's taken so long before this review.

I really like the principle of this chance, however, I do have some questions.

  • If I remember correctly, it was possible at some point to compile the PCRE extension without UTF8 support. Should that be taken into account as this package still supports PHP 5.4 ?
  • Is there a specific reason to use the POSIX character classes instead of the escape sequences for Unicode properties ?
    IIRC (again) the POSIX character classes may not always support Unicode depending on the PCRE version. Should that be taken into account as this package still supports PHP 5.4 ?
  • Will using the Unicode PCRE option for all uses of this function (while the majority of code is likely using ASCII based names) have an impact on performance ?

@julienfalque
Copy link
Author

  • If I remember correctly, it was possible at some point to compile the PCRE extension without UTF8 support. Should that be taken into account as this package still supports PHP 5.4 ?

I would say this should be taken into account but I'm not sure there's a reliable way to detect the (lack of) UTF-8 support.

  • Is there a specific reason to use the POSIX character classes instead of the escape sequences for Unicode properties ?
    IIRC (again) the POSIX character classes may not always support Unicode depending on the PCRE version. Should that be taken into account as this package still supports PHP 5.4 ?

No specific reason, I can use \p{Lu}/\p{Ll} if you prefer.

  • Will using the Unicode PCRE option for all uses of this function (while the majority of code is likely using ASCII based names) have an impact on performance ?

To be honest I don't know. I guess it will have a negative impact but barely noticeable.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants