Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Respect all sniffs when reviewing PHP_CodeSniffer itself #3914

Closed
wants to merge 5 commits into from
Closed

Respect all sniffs when reviewing PHP_CodeSniffer itself #3914

wants to merge 5 commits into from

Commits on Oct 29, 2023

  1. Flag warnings as well as errors

    @fredden
    fredden committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    467c6cb View commit details
    Browse the repository at this point in the history

  2. Ignore Generic.Files.LineLength 

    This was previously ignored due to the use of '-n' to ignore all warnings.
There are too many violations of this sniff to warrant fixing these here.
    @fredden
    fredden committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    84cf5af View commit details
    Browse the repository at this point in the history

  3. Adjust working to avoid false positive warning

    @fredden
    fredden committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    715e259 View commit details
    Browse the repository at this point in the history

  4. Fix use of incorrect tag

    @fredden
    fredden committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    affe41c View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Remove now-unnecessary upgrade of warning to error

    @fredden
    fredden committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a81e466 View commit details
    Browse the repository at this point in the history