Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

linux: lazy call XInitThreads #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Adphi
Copy link

@Adphi Adphi commented Apr 17, 2023

This prevents a program that can run as a command line tool from displaying "Unable to init server: Could not connect: Connection refused".

Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
@Adphi Adphi changed the title linux: lazy call to XInitThreads linux: lazy call XInitThreads Apr 18, 2023
@sqweek
Copy link
Owner

sqweek commented May 11, 2023

I looked at this PR when you first opened it and was going to do something with it but I haven't had much bandwidth lately sorry.

Thanks for your work! The change makes sense, but I'd like to take it a bit further before landing it:

  1. rename checkStatus() to lazyInit() or similar
  2. drop the initSuccess global (ie. panic() within the lazy init block that calls gtk_init_check)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants