Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Worktree: improve build index performance. #1179

Merged
merged 4 commits into from
Jul 25, 2019
Merged

Worktree: improve build index performance. #1179

merged 4 commits into from
Jul 25, 2019
+83 −18

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Jul 14, 2019

ref: #1170

orisano and others added 3 commits June 29, 2019 04:08
@orisano
test: add PlainClone benchmark
b8d9627 
Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>
@orisano
feat: improve clone performance on hotspot
5fd82ef 
Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>
@orisano
feat: use CopyBuffer and sync.Pool
3772538 
Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>
@orisano
Copy link
Contributor Author

orisano commented Jul 14, 2019 •
edited
Loading 

name          old time/op    new time/op    delta
PlainClone-4      605s ± 4%      249s ± 7%  -58.91%  (p=0.008 n=5+5)

name          old alloc/op   new alloc/op   delta
PlainClone-4    64.9GB ± 0%    56.1GB ± 0%  -13.48%  (p=0.008 n=5+5)

name          old allocs/op  new allocs/op  delta
PlainClone-4      117M ± 0%      118M ± 0%   +0.57%  (p=0.008 n=5+5)

@mcuadros mcuadros requested a review from jfontan July 16, 2019 20:54
@jfontan
Copy link
Contributor

jfontan commented Jul 18, 2019

I believe you can also add the changes in storage/filesystem/index.go from #1170. These should improve speed even more.

@orisano
feat: use bufio.Writer on SetIndex
ee7afbf 
Signed-off-by: Nao YONASHIRO <owan.orisano@gmail.com>
@orisano
Copy link
Contributor Author

orisano commented Jul 18, 2019

Added!

@jfontan
Copy link
Contributor

jfontan commented Jul 18, 2019

@orisano Thanks!

@mcuadros it LGTM

@mcuadros mcuadros changed the title feat: improve build index performance. Worktree: improve build index performance. Jul 25, 2019
@mcuadros mcuadros merged commit 8beb3ee into src-d:master Jul 25, 2019
@sapk sapk mentioned this pull request Jul 31, 2019
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jfontan jfontan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orisano @jfontan @mcuadros