This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Lazily load object index. #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
suggested changes
Apr 6, 2017
storage/filesystem/object.go
Outdated
| packs, err := s.dir.ObjectPacks() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| for _, h := range packs { | ||
| if err := s.loadIdxFile(h); err != nil { | ||
| idxfile, err := s.dir.ObjectPackIdx(h) |
There was a problem hiding this comment.
can we move this to a function?
There was a problem hiding this comment.
Why? I moved it out of the function since it was a fairly straightforward piece of code...
There was a problem hiding this comment.
because with this you can hide some complexity in this function, also this will help to simplify the code, putting the close in a defer, and inline err check.
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 77.36% 77.37% +<.01%
==========================================
Files 117 117
Lines 8019 8133 +114
==========================================
+ Hits 6204 6293 +89
- Misses 1156 1164 +8
- Partials 659 676 +17
Continue to review full report at Codecov.
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #327
Now with passing tests.