This repository was archived by the owner on Sep 11, 2020. It is now read-only.
transport: ssh, NewPublicKeys helper #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
suggested changes
Apr 18, 2017
| @@ -13,6 +14,8 @@ import ( | |||
| "golang.org/x/crypto/ssh/agent" | |||
| ) | |||
|
|
|||
| const DefaultSSHUsername = "git" | |||
There was a problem hiding this comment.
Maybe just DefaultUsername? It's already ssh package.
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 76.69% 76.63% -0.07%
==========================================
Files 122 122
Lines 8441 8449 +8
==========================================
+ Hits 6474 6475 +1
- Misses 1258 1262 +4
- Partials 709 712 +3
Continue to review full report at Codecov.
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342