-
Notifications
You must be signed in to change notification settings - Fork 534
format/packfile: improve binary delta algorithm #400
Conversation
Using the same source and target to create the deltas:
|
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 77.71% 77.09% -0.63%
==========================================
Files 125 124 -1
Lines 9106 9001 -105
==========================================
- Hits 7077 6939 -138
- Misses 1247 1303 +56
+ Partials 782 759 -23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a reference to the paper in a comment, so next person to review, modify or use your code knows how to understand it and also to give credit to the original authors.
Implemented algorithm described in "File System Support for Delta Compression" paper, from "Joshua P. MacDonald".
@alcortesm I added the name of the author and the paper title, because the link can disappear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent call.
I would have added that to the code itself, close to where people will need it, instead of on the commit message.
Implement Xdelta algorithm from this paper (http://pop.xmailserver.net/xdfs.pdf) using adler32 checksum for fingerprinting and 16 bytes chunks, like in git.
Fixes #390