This repository was archived by the owner on Sep 11, 2020. It is now read-only.
packfile: improve performance of delta generation #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveats
I kept the old API for deltas untouched and added some private methods that reuse indexes, so the methods can be used outside and the index is automatically created.
I ported a modified version of JGit's DeltaIndex and DeltaIndexScanner that is faster (not much more, though) and, somehow, make the encode process faster. A process that consistently took ~2m30s before now takes ~1m with this. This might be caused by a bug in the index, of course, but everything seems to be ok according to the tests and some manual check I did with the aforementioned process.