This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: the commit walker can skip externally-seen commits #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the revlist is computing the set of hashes needed to transfer, it doesn't need to walk over commits it has already processed. So, it can instruct the commit walker not to walk those commits by passing in its own `seen` map. For a 36K object repo, this brought the time for `revlist.Objects` down from 50s to 30s.
erizocosmico
approved these changes
Sep 12, 2017
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
- Coverage 78.32% 78.16% -0.17%
==========================================
Files 130 130
Lines 10092 10344 +252
==========================================
+ Hits 7905 8085 +180
- Misses 1342 1414 +72
Partials 845 845
Continue to review full report at Codecov.
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the revlist is computing the set of hashes needed to transfer, it doesn't need to walk over commits it has already processed. So, it can instruct the commit walker not to walk those commits by passing in
its own
seenmap.For a 36K object repo, this brought the time for
revlist.Objectsdown from 50s to 30s.