This repository was archived by the owner on Sep 11, 2020. It is now read-only.
git: worktree, add Grep() method for git grep #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
suggested changes
Dec 11, 2017
options.go
Outdated
| // GrepOptions describes how a grep should be performed. | ||
| type GrepOptions struct { | ||
| // Pattern is the match pattern. | ||
| Pattern string |
There was a problem hiding this comment.
Itstead of accepting a string, I would prefer a *regexp.Regexp with this the people can speed that the process with precompilled expressions.
options.go
Outdated
| // Pattern is the match pattern. | ||
| Pattern string | ||
| // IgnoreCase enables case insensitive match. | ||
| IgnoreCase bool |
There was a problem hiding this comment.
If we accept the type instead of the string, this is not need it.
worktree.go
Outdated
| } | ||
|
|
||
| // Iterate through the files and look for any matches. | ||
| err = fileiter.ForEach(func(file *object.File) error { |
There was a problem hiding this comment.
can we put this code in a private function?
worktree_test.go
Outdated
| TreeName: "6ecf0ef2c2dffb796033e5a02219af86ec6584e5", | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I prefer the open and close brace in the same line.
Signed-off-by: Sunny <me@darkowlzz.space>
Signed-off-by: Sunny <me@darkowlzz.space>
Signed-off-by: Sunny <me@darkowlzz.space>
Signed-off-by: Sunny <me@darkowlzz.space>
|
mcuadros
approved these changes
Dec 12, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implemented grep on worktree with options to
match ignoring case, invert match and specify pathspec. Also, a commit hash or reference can be used to specify the worktree to search.