This repository was archived by the owner on Sep 11, 2020. It is now read-only.
git: Worktree.Grep() support multiple patterns and pathspecs #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
suggested changes
Dec 19, 2017
worktree.go
Outdated
| @@ -771,8 +771,24 @@ func findMatchInFiles(fileiter *object.FileIter, treeName string, opts *GrepOpti | |||
|
|
|||
| // Iterate through the files and look for any matches. | |||
| err := fileiter.ForEach(func(file *object.File) error { | |||
There was a problem hiding this comment.
can we move this to his own fuction, is getting big
worktree.go
Outdated
| @@ -785,15 +801,22 @@ func findMatchInFiles(fileiter *object.FileIter, treeName string, opts *GrepOpti | |||
| contentByLine := strings.Split(content, "\n") | |||
| for lineNum, cnt := range contentByLine { | |||
| addToResult := false | |||
Signed-off-by: Sunny <me@darkowlzz.space>
darkowlzz
force-pushed
the
grep-multiple-patterns-pathspec
branch
from
3d6d549 to
4ead334
Compare
|
Divided the huge block of code into 2 separate functions,
Looks small and simple now. Hope this works. |
mcuadros
approved these changes
Dec 19, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sunny me@darkowlzz.space
Fixes #693