This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Set default pack window size in config #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config is not initialized with the default window size. Without this the window size is 0 by default and packfile code is unable to generate deltas. Signed-off-by: Javi Fontan <jfontan@gmail.com>
ajnavarro
approved these changes
Jan 9, 2018
mcuadros
suggested changes
Jan 9, 2018
config/config.go
Outdated
| Remotes: make(map[string]*RemoteConfig), | ||
| Submodules: make(map[string]*Submodule), | ||
| Raw: format.New(), | ||
| } | ||
|
|
||
| config.Pack.Window = defaultPackWindow |
Signed-off-by: Javi Fontan <jfontan@gmail.com>
mcuadros
reviewed
Jan 10, 2018
config/config.go
Outdated
| Remotes: make(map[string]*RemoteConfig), | ||
| Submodules: make(map[string]*Submodule), | ||
| Raw: format.New(), | ||
| } | ||
|
|
||
| config.Pack.Window = defaultPackWindow |
There was a problem hiding this comment.
Can you make defaultPackWindow public and document it?
Signed-off-by: Javi Fontan <jfontan@gmail.com>
mcuadros
approved these changes
Jan 10, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config is not initialized with the default window size. Without this the window size is 0 and packfile code is unable to generate deltas.