This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: cache, modify cache to delete more than one item to free space #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version could only delete the oldest used object. If the object to cache was bigger than the space freed it could not be added. Also the decoder adds bases to the cache when they are needed. This change increases the speed creating indexes 2x. Signed-off-by: Javi Fontan <jfontan@gmail.com>
erizocosmico
approved these changes
Jan 16, 2018
mcuadros
approved these changes
Jan 16, 2018
ajnavarro
reviewed
Jan 16, 2018
| @@ -55,18 +55,14 @@ func (c *ObjectLRU) Put(obj plumbing.EncodedObject) { | |||
| return | |||
| } | |||
|
|
|||
| if c.actualSize+objSize > c.MaxSize { | |||
| for c.actualSize+objSize > c.MaxSize { | |||
There was a problem hiding this comment.
Should we check if the object to add is bigger than the cache size to do not remove everything?
There was a problem hiding this comment.
nevermind, is already checked before the for.
|
Will be nice have a test here. |
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
mcuadros
changed the title
jfontan
added a commit
to jfontan/old-go-git
that referenced
this pull request
Jan 24, 2018
Resolving cycles relied on ObjectToPack objects having Original. This is no longer true with the changes from src-d#720. This commit changes: * Save original type, hash and size in ObjectToPack * Use SetObject to set both Original and resolved type, hash and size * Restore original object before using BackToOriginal (cycle resolution) * Update encoder test to check this case Signed-off-by: Javi Fontan <jfontan@gmail.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version could only delete the oldest used object. If the
object to cache was bigger than the space freed it could not be added.
Also the decoder adds bases to the cache when they are needed.
This change increases the speed creating indexes 2x.