Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set note date when the path begin with a timestamp #552

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

TristanCacqueray
Copy link
Contributor

This change simplifies timeline creation by setting the date metadata from the filename when it begins with YYYY-MM-DD-.

@TristanCacqueray TristanCacqueray force-pushed the note-date-fp branch 2 times, most recently from f62b727 to 9caa7a9 Compare September 30, 2024 01:20
@srid srid changed the title Set note time when the path begin with a timestamp Set note date when the path begin with a timestamp Sep 30, 2024
Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you:

  • fix the CI failure
  • mention this in the docs around here
image

This change simplifies timeline creation by setting the date metadata
from the filename when it begins with `YYYY-MM-DD`.
@TristanCacqueray
Copy link
Contributor Author

Great, I've updated the change.

Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿 I don't have the time to test this locally but I trust that you have done so.

@srid srid merged commit 013be93 into srid:master Sep 30, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants