Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add compareTo aliases #99

Merged
merged 17 commits into from
Oct 4, 2022
Merged

Add compareTo aliases #99

merged 17 commits into from
Oct 4, 2022

Conversation

d-mon-
Copy link
Contributor

@d-mon- d-mon- commented Aug 30, 2022

fixes: #73

I adopted sameValue at the end.
Using equalsLoosely would have probably required to rename equals to equalsStrict and @deprecated the previous method to not confuse people.
It would also make the eq alias ambiguous. So, instead I kept the shortest and most practical option.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 90.04% // Head: 90.10% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (b9e0c77) compared to base (02869ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   90.04%   90.10%   +0.06%     
==========================================
  Files           1        1              
  Lines        1366     1375       +9     
  Branches      420      420              
==========================================
+ Hits         1230     1239       +9     
  Misses         73       73              
  Partials       63       63              
Impacted Files Coverage Δ
src/bigdecimal.ts 90.10% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I think we can merge it for 1.3.0. Left minor comments.

src/bigdecimal.ts Outdated Show resolved Hide resolved
src/bigdecimal.ts Outdated Show resolved Hide resolved
src/bigdecimal.ts Outdated Show resolved Hide resolved
@srknzl
Copy link
Owner

srknzl commented Sep 30, 2022

Note: I think we can just merge this PR instead of merging both PRs. You can update the description and title of this PR if you want

@srknzl srknzl added this to the 1.3.0 milestone Sep 30, 2022
@srknzl srknzl added the enhancement New feature or request label Sep 30, 2022
@srknzl srknzl linked an issue Sep 30, 2022 that may be closed by this pull request
@d-mon- d-mon- changed the title Add compareTo === 0 alias Add compareTo aliases Oct 4, 2022
@d-mon- d-mon- mentioned this pull request Oct 4, 2022
@d-mon- d-mon- requested a review from srknzl October 4, 2022 08:49
@srknzl srknzl merged commit 1024ebc into srknzl:main Oct 4, 2022
@d-mon-
Copy link
Contributor Author

d-mon- commented Nov 18, 2022

Hello @srknzl,
I was wondering if we could do a quick release to include these changes in npm ?
thank you in advance.

@srknzl
Copy link
Owner

srknzl commented Nov 18, 2022

Sure, let me do it in the weekend. @d-mon-

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extends API to support compareTo aliases (===, >, >=, etc...)
2 participants