-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add compareTo aliases #99
Conversation
This reverts commit a3f4e5c.
Codecov ReportBase: 90.04% // Head: 90.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 90.04% 90.10% +0.06%
==========================================
Files 1 1
Lines 1366 1375 +9
Branches 420 420
==========================================
+ Hits 1230 1239 +9
Misses 73 73
Partials 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I think we can merge it for 1.3.0. Left minor comments.
Note: I think we can just merge this PR instead of merging both PRs. You can update the description and title of this PR if you want |
Hello @srknzl, |
Sure, let me do it in the weekend. @d-mon- |
fixes: #73
I adopted
sameValue
at the end.Using
equalsLoosely
would have probably required to renameequals
toequalsStrict
and@deprecated
the previous method to not confuse people.It would also make the
eq
alias ambiguous. So, instead I kept the shortest and most practical option.