Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expand error handler interfaces #11

Merged
merged 4 commits into from
Nov 3, 2017
Merged

Expand error handler interfaces #11

merged 4 commits into from
Nov 3, 2017

Conversation

izumin5210
Copy link
Member

@izumin5210 izumin5210 commented Nov 3, 2017

WHY

In the next version, i plan to make handlers receive request/response values...

WHAT

Make interfaces extendable

@codecov-io
Copy link

codecov-io commented Nov 3, 2017

Codecov Report

Merging #11 into master will decrease coverage by 26.04%.
The diff coverage is 48.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #11       +/-   ##
===========================================
- Coverage      84%   57.95%   -26.05%     
===========================================
  Files           3        3               
  Lines          50       88       +38     
===========================================
+ Hits           42       51        +9     
- Misses          7       36       +29     
  Partials        1        1
Impacted Files Coverage Δ
interceptors.go 24% <15%> (-30.55%) ⬇️
utils.go 40.9% <40.9%> (-34.1%) ⬇️
handlers.go 87.8% <80.76%> (-8.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c78f2...4113237. Read the comment docs.

@izumin5210 izumin5210 changed the title [WIP] API improvement Expand error handler interfaces Nov 3, 2017
@izumin5210
Copy link
Member Author

coverage is down because increase loc for streaming server

@izumin5210 izumin5210 merged commit 77bbe06 into master Nov 3, 2017
@izumin5210 izumin5210 deleted the izumin5210/improve branch November 3, 2017 15:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants