Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add new error handler for catching reportable errors for unary server #12

Merged
merged 2 commits into from
Nov 4, 2017

Conversation

izumin5210
Copy link
Member

WHY

I wanna report errors with request contexts...!

WHAT

Add new error handler for catching reportable errors with request parameter and server info.

@codecov-io
Copy link

codecov-io commented Nov 4, 2017

Codecov Report

Merging #12 into master will increase coverage by 4.79%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   57.95%   62.74%   +4.79%     
==========================================
  Files           3        4       +1     
  Lines          88      102      +14     
==========================================
+ Hits           51       64      +13     
- Misses         36       37       +1     
  Partials        1        1
Impacted Files Coverage Δ
unary_server_error_handlers.go 92.85% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77bbe06...a5e9802. Read the comment docs.

@izumin5210 izumin5210 merged commit c2d20b9 into master Nov 4, 2017
@izumin5210 izumin5210 deleted the izumin5210/unary-server-error-handlers branch November 4, 2017 16:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants