Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(git hook): add precommit-hook to handle validation checks #903

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

EspiraMarvin
Copy link
Contributor

  • This change adds validation check for linting, formatting & test concurrently on commit

Fixes #880

@EspiraMarvin EspiraMarvin force-pushed the add-precommit-hook branch 2 times, most recently from 9f9b905 to e3f7ed3 Compare March 17, 2024 16:31
@ronzulu
Copy link
Collaborator

ronzulu commented Mar 17, 2024

Hi @EspiraMarvin does this mean that the lint/test operations will occur whenever a developer pushes local commits to GitHub. I.e. these operations will occur regardless of whether or not there is an associated PR?

Thanks
Ronny

@EspiraMarvin
Copy link
Contributor Author

@ronzulu Yes, according to the PR, the operations will run regardless of whether or not there is an associated PR.

@ronzulu
Copy link
Collaborator

ronzulu commented Mar 19, 2024

@ronzulu Yes, according to the PR, the operations will run regardless of whether or not there is an associated PR.

Thanks. I think this is really helpful.

@st3v3nmw
Copy link
Owner

@EspiraMarvin 👀 ...

 - add precommit hook to format, lint and test
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.96%. Comparing base (f2c5739) to head (3051169).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
- Coverage   93.16%   92.96%   -0.20%     
==========================================
  Files          42       42              
  Lines        4537     4537              
  Branches      644      371     -273     
==========================================
- Hits         4227     4218       -9     
- Misses        308      317       +9     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EspiraMarvin
Copy link
Contributor Author

@EspiraMarvin 👀 ...

@st3v3nmw this is ready

Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@st3v3nmw st3v3nmw merged commit 73cc420 into st3v3nmw:master Oct 20, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add git hooks with husky
4 participants