PgSTAC: API hydration of search result items #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcfarland
commented
Apr 27, 2022
6 tasks
Initial changes to get most tests passing.
This was done in a pairing session with @mmcfarland
Use of the fields extension can result in the return of invalid stac items if excludes is used on required attributes. When injecting item links, don't attempt to build links for which needed attributes aren't available. When API Hydrate is enabled, the required attributes are preserved prior to filtering and are used in the link generation.
mmcfarland
force-pushed
the
feature/hydrate
branch
from
7d4a348 to
c86e0d9
Compare
In practice, an asset on a base_item and an item may have mergable dicts (ie, raster bands).
This will be used by implementors who need app state which is stored on request.
mmcfarland
force-pushed
the
feature/hydrate
branch
from
dac82fe to
7bda2ba
Compare
The hydrate function was improved and moved to pypgstac so it could be used in other projects outside of stac-fastapi. It was developed with a corresponding dehydrate function to ensure parity between the two. The version of pypgstac is unpublished and pinned to a draft commit at the point and will be upgraded subsequently.
Correctly supports deeply nested property keys in both include and exclude, as well as improves variable naming, comments, and test cases.
mmcfarland
force-pushed
the
feature/hydrate
branch
from
4d4db9f to
bf3acd5
Compare
mmcfarland
commented
May 5, 2022
Get tests to pass with 0.6.0
mmcfarland
commented
May 12, 2022
lossyrob
reviewed
May 12, 2022
|
@mmcfarland one outstanding question about dependencies, but otherwise LGTM! Will hit approve after that convo wraps up. |
lossyrob
approved these changes
May 12, 2022
This was referenced Jun 24, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
nohydrateoption is set.PR Checklist:
pre-commit run --all-files)make test)make docs)