fix precommit #75
Merged
fix precommit #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
geospatial-jeff
commented
Jan 26, 2021
•
geospatial-jeff
commented
- Fixes precommit config so black/isort don't conflict.
- Re-lints files.
geospatial-jeff
changed the base branch from
master
to
update-database-connection
kylebarron
reviewed
Jan 26, 2021
| @@ -22,7 +21,7 @@ repos: | |||
| # E501 let black handle all line length decisions | |||
| # W503 black conflicts with "line break before operator" rule | |||
| # E203 black conflicts with "whitespace before ':'" rule | |||
| '--ignore=E501,W503,E203'] | |||
| '--ignore=E501,W503,E203,C901'] | |||
There was a problem hiding this comment.
Just use profile=black for isort. https://pycqa.github.io/isort/docs/configuration/black_compatibility/
There was a problem hiding this comment.
Oh nevermind I see that elsewhere in the config.
kylebarron
approved these changes
Jan 26, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.