Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Make invocation ID optional #188

Merged
merged 5 commits into from
Jun 7, 2021
Merged

Conversation

siegfriedweber
Copy link
Member

Fixes #150

@siegfriedweber siegfriedweber force-pushed the make_invocation_id_optional branch from 22d4800 to 612795e Compare June 1, 2021 12:29
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: please ignore. I used the wrong agent version.

I'm not sure if this PR should cover the entire pod lifecycle or just the kubectl logs usecase.

I get the following error on Centos 7 when creating a single node Zookeeper cluster:

Jun 04 09:09:05 1825a20b6a8e stackable-agent[86]: [2021-06-04T09:09:05Z ERROR stackable_agent::provider::states::pod::starting] Error receiving InvocationID of unit [default-zookeeper-simple-default-server-1825a20b6a8e-zookeeper.service]. org.freedesktop.DBus.Error.UnknownProperty: Unknown property or interface.
Jun 04 09:09:05 1825a20b6a8e stackable-agent[86]: [2021-06-04T09:09:05Z ERROR krator::state] Object state machine exited with error. error=Error receiving InvocationID of unit [default-zookeeper-simple-default-server-1825a20b6a8e-zookeeper.service]. org.freedesktop.DBus.Error.UnknownProperty: Unknown property or interface.

So I cannot test the logs call because the pod never reaches a running state.

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: please ignore. I used the wrong agent version.

On Debian I don't see the featureLogs annotation of the pod:

Annotations:    <none>

But kubectl logs works.

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@siegfriedweber siegfriedweber merged commit d31fc51 into main Jun 7, 2021
@siegfriedweber siegfriedweber deleted the make_invocation_id_optional branch June 7, 2021 07:23
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable kubectl logs on systems without an invocation ID
2 participants