This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Adds bootstrapping of certificates and kubeconfig to agent #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a bootstrap config is provided via the --bootstrap-file command line option and no valid config can be found in the usual places the agent will attempt to bootstrap a Kubeconfig via the configuration in the bootstrap file. Additionally this code will check if the provided files from --server-cert-file and --server-key-file exist. If not, it will create a key pair and signing request, upload this to the apiserver and wait for the certificate to be provided by a controller.
lfrancke
suggested changes
Feb 25, 2021
| // Bootstrap a kubernetes config, if no valid config is found | ||
| // This also generates certificates for the webserver the krustlet | ||
| // runs | ||
| let kubeconfig = kubelet::bootstrap( |
There was a problem hiding this comment.
I looked at the krustlet docs (not code) for this and I can't see the "if no valid config is found" part. Are you sure this is the case?
There was a problem hiding this comment.
My comment is based on this documentation and my take on what I saw in the code.
There was a problem hiding this comment.
Alright, I see. I only looked at the docs
lfrancke
approved these changes
Feb 25, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bootstrap config is provided via the --bootstrap-file command line option and no valid config can be found in the usual places the agent will attempt to bootstrap a Kubeconfig via the configuration in the bootstrap file.
Additionally this code will check if the provided files from --server-cert-file and --server-key-file exist. If not, it will create a key pair and signing request, upload this to the api-server and wait for the certificate to be provided by a controller.