Skip to content

fix(stack/trino-iceberg): Use Minio with TLS, increase memory limits #176

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 12 commits into from
Mar 19, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Mar 18, 2025

Analogue to #174 but for trino-iceberg demo

@adwk67 adwk67 self-requested a review March 18, 2025 15:59
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 18, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing from nightly - when I run the first few steps with trino-cli, I get s3-related errors:

trino> CREATE SCHEMA lakehouse.tpch WITH (location = 's3a://lakehouse/tpch');
Query 20250318_162924_00000_pcdff failed: Invalid location URI: s3a://lakehouse/tpch

@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Mar 19, 2025

@adwk67 I had this problem too. Does it come right if you restart both Trino pods?

I was hoping it was just my impatience, but it seems to be occurring for others.


Edit: I just noticed the comment was from yesterday, and more work as been done today to get minio with TLS working properly. Ignore my comment for now.

@xeniape xeniape changed the title fix(stack/trino-iceberg): Use Minio with TLS fix(stack/trino-iceberg): Use Minio with TLS, increase memory limits Mar 19, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xeniape xeniape added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 0695d69 Mar 19, 2025
2 checks passed
@xeniape xeniape deleted the fix/trino-iceberg-minio-tls branch March 19, 2025 15:56
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Mar 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants