Skip to content

feat(nifi): Restore flows directly from JSON file instead of using versioning #194

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented Mar 26, 2025

While the demos are currently working, NiFi 2 reports a status drift to the versioned components when comparing the deployed state with the state in Git. This is wrong, but we can't really work around it and it might irritate users.
Also, we saw some problems related to Github's rate limits when installing NiFi demos too often on the same machine.

This PR drops the whole process of versioning, since it is not needed for the demos. It was just our first approach as a replacement for the "templates" functionality that was removed with NiFi 2. Instead of using versioning, we now download the JSON files from Github via HTTP and then directly create the Flows via NiFis /process-groups/upload API.

@dervoeti dervoeti force-pushed the feat/nifi-drop-flow-versioning branch from 9419581 to dbae86d Compare March 26, 2025 14:13
@dervoeti dervoeti force-pushed the feat/nifi-drop-flow-versioning branch from dbae86d to 2ac3a07 Compare March 26, 2025 14:15
@dervoeti dervoeti requested review from maltesander and xeniape March 26, 2025 14:29
@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Mar 26, 2025
@dervoeti dervoeti changed the title feat(nifi): Restore flows directly from JSON file and not via versioning feat(nifi): Restore flows directly from JSON file instead of using versioning Mar 26, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@dervoeti dervoeti added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 1744be0 Mar 26, 2025
2 checks passed
@dervoeti dervoeti deleted the feat/nifi-drop-flow-versioning branch March 26, 2025 14:44
@dervoeti dervoeti self-assigned this Mar 26, 2025
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Mar 26, 2025
dervoeti added a commit that referenced this pull request Mar 26, 2025
…rsioning (#194)

feat: remove versioning from flow restore process
dervoeti added a commit that referenced this pull request Mar 26, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 31, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants