Skip to content

chore(⏲): Use fast download mirrors #1061

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2025
Merged

chore(⏲): Use fast download mirrors #1061

merged 6 commits into from
Apr 24, 2025

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Apr 23, 2025 •
edited
Loading

Description

Note

This came out of the 25.3.0 Release Retro.

I did not add a flag as was discussed in the retro, but I believe the help text for switching URLs is easy enough.

  • Use fast download mirrors (help text is emitted so that the user can change the BASE_DOWNLOAD_URL to the archive URL for example.
  • Add a download/upload progress-bar since this is run by people.
  • Only emit GPG key warning/help if the verification failed.

@NickLarsenNZ NickLarsenNZ self-assigned this Apr 23, 2025
@NickLarsenNZ NickLarsenNZ changed the title chore: Use fast download mirrors chore(⏲): Use fast download mirrors Apr 23, 2025
@NickLarsenNZ NickLarsenNZ mentioned this pull request Apr 23, 2025
Open
29 tasks
@NickLarsenNZ NickLarsenNZ requested a review from Techassi April 23, 2025 19:59
@NickLarsenNZ NickLarsenNZ added the release-retro/25.3.0 Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0 label Apr 24, 2025
Techassi
Techassi reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, just a few questions and suggestions.

NickLarsenNZ and others added 2 commits April 24, 2025 09:26
@NickLarsenNZ @Techassi
Apply suggestions from code review
baa7f56 
Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>
@NickLarsenNZ
chore: Make output more consistent
87f29f6
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit cbb5712 Apr 24, 2025
3 checks passed
@NickLarsenNZ NickLarsenNZ deleted the use-fast-download-mirrors branch April 24, 2025 07:44
labrenbe pushed a commit that referenced this pull request May 8, 2025
@NickLarsenNZ @Techassi @labrenbe
chore(⏲): Use fast download mirrors (#1061)
f044dac 
* chore: Use fast download mirrors

* chore: Show download progress bar

* chore: Improve gpg key warning message

* chore: Show upload progress bar

Thanks to <https://bashupload.com/how_to_upload_progress_curl>

* Apply suggestions from code review

Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>

* chore: Make output more consistent

---------

Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
release-retro/25.3.0 Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickLarsenNZ @Techassi