-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: HBase resolvable endpoints #1159
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
…ort-and-use-alternative-p.patch Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
…ort-and-use-alternative-p.patch Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor notes, but we're definitely closing in.
If you want to rush it in, we could probably merge 0005 as is, and split 0006 into a separate PR (though that will definitely require coordinating with the operator PR too..).
hbase/hbase/stackable/patches/2.6.1/0006-Update-property-usage-for-bound-ports.patch
Outdated
Show resolved
Hide resolved
hbase/hbase/stackable/patches/2.6.1/0006-Update-property-usage-for-bound-ports.patch
Outdated
Show resolved
Hide resolved
hbase/hbase/stackable/patches/2.6.1/0006-Update-property-usage-for-bound-ports.patch
Outdated
Show resolved
Hide resolved
hbase/hbase/stackable/patches/2.6.1/0006-Update-property-usage-for-bound-ports.patch
Show resolved
Hide resolved
hbase/hbase/stackable/patches/2.6.1/0006-Update-property-usage-for-bound-ports.patch
Show resolved
Hide resolved
hbase/hbase/stackable/patches/2.6.1/0006-Update-property-usage-for-bound-ports.patch
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* patches I * patches I * wip: patch hbase to use listener endpoints * changed rendering * rework patch for UI * Consistently override the advertised ports * add listener endpoint and info port to hbase-site.xml * patch and entrypoint refactoring * hbase: use listener service for region mover * hbase: patch for 2.6.2 endpoints * removed dead variable * Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se> * Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se> * review comments: added constants etc. * set RPC_CLIENT_SPECIFY_HOST to true by default * corrected constant descriptions * updated 2.6.2 patch * patch 2.6.1 to reverse bound/advertised properties * property re-working for 2.6.2 * provide advertised port as a fallback, removed changes to test class --------- Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Description
fixes: stackabletech/hbase-operator#641
Warning
Merge this at the same time as stackabletech/hbase-operator#639, otherwise tests will break!
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.