Skip to content

feat: HBase resolvable endpoints #1159

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 27 commits into from
Jul 8, 2025
Merged

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Jun 11, 2025

Description

fixes: stackabletech/hbase-operator#641

Warning

Merge this at the same time as stackabletech/hbase-operator#639, otherwise tests will break!

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@adwk67 adwk67 moved this to Development: In Progress in Stackable Engineering Jun 16, 2025
@adwk67 adwk67 self-assigned this Jun 16, 2025
@adwk67 adwk67 marked this pull request as ready for review June 16, 2025 14:10
@adwk67 adwk67 moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jun 16, 2025
@nightkr nightkr self-requested a review June 24, 2025 10:34
@nightkr nightkr moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 24, 2025
adwk67 and others added 4 commits June 24, 2025 17:44
…ort-and-use-alternative-p.patch

Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
…ort-and-use-alternative-p.patch

Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor notes, but we're definitely closing in.

If you want to rush it in, we could probably merge 0005 as is, and split 0006 into a separate PR (though that will definitely require coordinating with the operator PR too..).

Copy link
Contributor

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickLarsenNZ NickLarsenNZ merged commit bf3aa92 into main Jul 8, 2025
2 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/hbase-resolvable-endpoints branch July 8, 2025 15:38
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jul 8, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 14, 2025
razvan pushed a commit that referenced this pull request Jul 22, 2025
* patches I

* patches I

* wip: patch hbase to use listener endpoints

* changed rendering

* rework patch for UI

* Consistently override the advertised ports

* add listener endpoint and info port to hbase-site.xml

* patch and entrypoint refactoring

* hbase: use listener service for region mover

* hbase: patch for 2.6.2 endpoints

* removed dead variable

* Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch

Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>

* Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch

Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>

* review comments: added constants etc.

* set RPC_CLIENT_SPECIFY_HOST to true by default

* corrected constant descriptions

* updated 2.6.2 patch

* patch 2.6.1 to reverse bound/advertised properties

* property re-working for 2.6.2

* provide advertised port as a fallback, removed changes to test class

---------

Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Development

Successfully merging this pull request may close these issues.

Use Node-IPs for external reachability and localities
6 participants