Skip to content

Change default user id and gid #916

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

Change default user id and gid #916

merged 3 commits into from
May 9, 2025

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Nov 5, 2024

Description

Part of stackabletech/issues#645

Change default user id and gid to the same ones we use in the operators themselves.
These are only the defaults that are used when a Pod does not specify their own securityContext.runAsUser or runAsGroup.

As of now all our operators do set these (and fsGroup) to 1000 and 0 respectively.
As the next step we want to remove that hardcoding so the default would then fall back to what we specify here.

Therefore I do believe that this PR should be a simple change with no downstream consequences until the PRs from stackabletech/issues#651 are merged.

Definition of Done Checklist

  • Changes are OpenShift compatible
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@stackable-bot
Copy link
Contributor

stackable-bot commented Nov 5, 2024

CLA assistant check
All committers have signed the CLA.

@lfrancke lfrancke force-pushed the push-kynqsyykoyxq branch from 062ee3f to 9c0ba33 Compare May 7, 2025 20:43
@lfrancke lfrancke marked this pull request as ready for review May 7, 2025 20:45
@lfrancke lfrancke moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering May 7, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 8, 2025
@lfrancke lfrancke requested a review from sbernauer May 8, 2025 15:11
@lfrancke lfrancke force-pushed the push-kynqsyykoyxq branch from bf5a6a4 to 826434c Compare May 8, 2025 15:39
@lfrancke lfrancke enabled auto-merge May 8, 2025 15:40
@lfrancke lfrancke added this pull request to the merge queue May 9, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 9, 2025
Merged via the queue into main with commit b4b5a33 May 9, 2025
3 checks passed
@lfrancke lfrancke deleted the push-kynqsyykoyxq branch May 9, 2025 05:37
@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 9, 2025
@lfrancke
Copy link
Member Author

lfrancke commented May 9, 2025

Release Notes

The default user id and group id used by all our docker images was 1000. This has now been changed to high random numbers (782252253 / 574654813 respectively). Additionally our operators also hardcoded these values. This also changed which means that the user ids and group ids will change as of this release. This is for security purposes to reduce the chance of overlaps with existing ids on the host.

@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 9, 2025
lfrancke added a commit that referenced this pull request May 12, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release/25.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants