Enable service discovery #150
Conversation
maltesander
added
type/enhancement
release-note
|
There is a little more work in terms of overrides to reflect that in the discovery. |
# Conflicts: # CHANGELOG.md
|
Are the changes to the product config intentional in here? |
| ) -> Result<BTreeMap<String, Option<String>>, ConfigError> { | ||
| Ok(BTreeMap::new()) | ||
| let mut config = BTreeMap::new(); | ||
| if file == HDFS_SITE_XML { |
There was a problem hiding this comment.
This seems unrelated to the discovery?
There was a problem hiding this comment.
Yes but required for the product config part.
| @@ -72,6 +74,21 @@ pub async fn reconcile_hdfs( | |||
| let namenode_podrefs = hdfs.pod_refs(&HdfsRole::NameNode)?; | |||
| let journalnode_podrefs = hdfs.pod_refs(&HdfsRole::JournalNode)?; | |||
|
|
|||
| let discovery_cm = build_discovery_configmap(&hdfs, &namenode_podrefs).map_err(|e| { | |||
There was a problem hiding this comment.
Maybe a stupid question, but isn't this written too early? If we write the configmap here and roll out new nodes in a later step (for example when first building the cluster) wouldn't those be missing from the configmap?
There was a problem hiding this comment.
The namenode_podrefs include all namenodes that will be created. Its calculated HdfsCluster::pod_refs().
| let mut hdfs_site_xml = String::new(); | ||
| let mut core_site_xml = String::new(); | ||
|
|
||
| for (property_name_kind, config) in rolegroup_config { |
There was a problem hiding this comment.
These changes also seem unrelated to the discovery?
There was a problem hiding this comment.
well i replaced the hardcoded config part with that builder thing to reuse it in the discovery, so it kinda is :)
rust/operator/src/lib.rs
Outdated
| @@ -1,3 +1,6 @@ | |||
| //mod discovery; | |||
Yes i changed some hardcoded stuff here and there and had to remove some defaults and if it is required or not. |
Description
hdfs-site.xmlandcore-site.xmlto reuse code for the rolegroup and discovery configmaps.HBase PR thats works with this stackabletech/hbase-operator#153
closes #137
closes #121
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information