-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Merged by Bors] - allow specifying pvc parameters #164
Conversation
@soenkeliebau has been working on integrating something similar into his resource management scheme (over at https://github.com/stackabletech/operator-rs/compare/feat/resource_config2, don't think he made a proper PR from what I can tell?). Might be worth talking to him about aligning this. |
Didn't know that. Thanks for the pointer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments. Ill test tomorrow. Can we have a readme for the kuttl tests? Its not explained how to properly run that with the test definition yaml?
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. @soenkeliebau should approve once he had a chance to look over this.
Locally the tests failed the first time (timeout 5min) and worked after the images were downloaded. Maybe we can increase the timeout for the install step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked it over and tested it, looks good to me.
One thing I noticed is that the tests specify resources but don't check if they get set in the pods / pod templates correctly. That migth be an improvement down the line that we could add.
But I am also happy for this to go in as is.
bors merge |
Pull request successfully merged into main. Build succeeded: |
Description
Fixes #67
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information