[Merged by Bors] - bump operator-rs to 0.27.1 #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesander
requested changes
Nov 25, 2022
There was a problem hiding this comment.
LGTM overall.
There are still some serde_yaml dependencies in the cargo files (not required anymore).
I stumbled over not creating a zookeeper znode config map. Can we just have a small assert in one of the tests, that the hdfs discovery map is created (https://github.com/stackabletech/zookeeper-operator/blob/main/tests/templates/kuttl/znode/00-assert.yaml)?
This does not have to be an extra tests, i think just the assert in e.g. smoke is enough.
Quick test with Hbase worked:
--- PASS: kuttl (359.79s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/smoke_hbase-2.4.12-stackable0.3.0_hdfs-3.3.3-stackable0.2.0_zookeeper-3.8.0-stackable0.8.0 (358.57s)
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
# Description Fixes #265 🟢 CI https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/28/ (updated)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #265
🟢 CI https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/28/ (updated)
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information