Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Merged by Bors] - Implement product image selection #281

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Implement product image selection #281

wants to merge 3 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 30, 2022 •
edited by maltesander
Loading

Description

  • Implement product image selection
  • Remove tools image usage

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander mentioned this pull request Nov 30, 2022
Closed
7 tasks
@maltesander maltesander self-requested a review November 30, 2022 09:55
maltesander
maltesander approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer
Copy link
Member Author

Started test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/29/

@sbernauer sbernauer changed the title Use Product image selection instead of version Implement product image selection Nov 30, 2022
@sbernauer sbernauer self-assigned this Nov 30, 2022
@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 30, 2022
@sbernauer @maltesander
Implement product image selection (#281)
7842348 
# Description

- [x] Implement product image selection
- [x] Remove tools image usage



Co-authored-by: maltesander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 30, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement product image selection [Merged by Bors] - Implement product image selection Nov 30, 2022
@bors bors bot closed this Nov 30, 2022
@bors bors bot deleted the product-image-selection branch November 30, 2022 10:30
@maltesander maltesander mentioned this pull request Nov 30, 2022
Closed
@sbernauer sbernauer added release/23.1.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change labels Nov 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels
release/23.1.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander