Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Merged by Bors] - Support specifying Service type #340

Closed
wants to merge 4 commits into from

Conversation

sbernauer
Copy link
Member

Description

For stackabletech/issues#360

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Verified

This commit was signed with the committer’s verified signature.
jGleitz Joshua Gleitze

Verified

This commit was signed with the committer’s verified signature.
jGleitz Joshua Gleitze
@sbernauer
Copy link
Member Author

Verified

This commit was signed with the committer’s verified signature.
jGleitz Joshua Gleitze
@sbernauer sbernauer requested a review from a team April 5, 2023 10:00
@sbernauer sbernauer self-assigned this Apr 5, 2023
@maltesander maltesander self-requested a review April 5, 2023 10:33

Verified

This commit was signed with the committer’s verified signature.
jjohannes Jendrik Johannes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test works

@sbernauer
Copy link
Member Author

bors r+
Test passed

bors bot pushed a commit that referenced this pull request Apr 5, 2023
@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support specifying Service type [Merged by Bors] - Support specifying Service type Apr 5, 2023
@bors bors bot closed this Apr 5, 2023
@bors bors bot deleted the feat/service-type branch April 5, 2023 11:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants