[Merged by Bors] - Rewrite with stateful sets #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackabletech/operator-templating repo. Original commit message: Fix my mistakes (#54) - I had a few outdated references to chart_testing.yaml in there - I accidentally dropped the "description field" from the Chart which causes lint to fail
maltesander
requested changes
Jan 27, 2022
There was a problem hiding this comment.
I ran the cluster it works. Some notes for the cargo.tomls
- authors = ["Stackable GmbH info@stackable.de"]
- edition = 2021 ? Is there a reason for keeping 2018?
- different strum versions in crd (0.22) vs operator (0.23)
- different tokio versions in operator-binary (1.13) vs operator (1.15)
I did not check the hdfs related correctness (that should probably be lars or jim).
I think we could reduce alot of complexity in the code if we fix the ports and use more of our builders.
commit d043c0a Author: Stacky McStackface <github@stackable.de> Date: Mon Jan 31 15:15:00 2022 +0000 Generated commit to update templated files based on rev 0994c92 in stackabletech/operator-templating repo. Original commit message: Allow operators access to Secret objects (#57) Fixes stackabletech/trino-operator#97
maltesander
approved these changes
Feb 1, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2022
## Description Fixes #38 *Please add a description here. This will become the commit message of the merge request later.* Co-authored-by: Stacky McStackface <stackable-bot@users.noreply.github.com> Co-authored-by: Stacky McStackface <github@stackable.de>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
stackable-bot
added a commit
that referenced
this pull request
Feb 10, 2022
…ackabletech/operator-templating repo. Original commit message: Make Renovate slightly less annoying (#68) * Minimize the Renovate PR window * Let Renovate update GitHub Actions pins in templating * Fix silly Renovate mistakes * Use the same Renovate schedule consistently * Also have Renovate manage jinja2 workflows
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38
Please add a description here. This will become the commit message of the merge request later.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information