Skip to content
This repository was archived by the owner on Feb 9, 2022. It is now read-only.

echo-service created to test "kubectl logs" #2

Merged
merged 3 commits into from
Apr 23, 2021
Merged

echo-service created to test "kubectl logs" #2

merged 3 commits into from
Apr 23, 2021

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Apr 22, 2021 •
edited
Loading

  • test-service renamed to noop-service
  • echo-service created

Closes stackabletech/agent#37

@siegfriedweber siegfriedweber requested a review from a team April 22, 2021 13:21
@siegfriedweber siegfriedweber self-assigned this Apr 22, 2021
soenkeliebau
soenkeliebau previously approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one suggestion, but happy to merge as is as well

soenkeliebau
soenkeliebau approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siegfriedweber siegfriedweber merged commit 2597b3a into stackabletech:main Apr 23, 2021
@siegfriedweber siegfriedweber deleted the logs branch April 23, 2021 09:31
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@soenkeliebau soenkeliebau soenkeliebau approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functionality to tail logs via kubectl (or similar tools)
2 participants
@siegfriedweber @soenkeliebau