Skip to content

refactor(stackable-versioned): Simplify attribute handling #1053

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jun 3, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jun 3, 2025

Part of stackabletech/issues#642.

This PR

  • simplifies the attribute handling
  • removes superfluous visibility modifiers to reduce visual clutter
  • adds a new changed() validation

@Techassi Techassi self-assigned this Jun 3, 2025
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Jun 3, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 3, 2025
@Techassi Techassi added this pull request to the merge queue Jun 3, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Jun 3, 2025
Merged via the queue into main with commit 1b610a8 Jun 3, 2025
8 checks passed
@Techassi Techassi deleted the refactor/stackable-versioned-attributes branch June 3, 2025 12:19
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants