Skip to content

fix: Prefix ui-http port endpoints with http:// #368

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

fix: Prefix ui-http port endpoints with http:// #368

merged 3 commits into from
Apr 10, 2025

Conversation

sbernauer
Copy link
Member

Description

Noticed in stackabletech/hbase-operator#639

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer changed the title Prefix ui-http port endpoints with http:// fix: Prefix ui-http port endpoints with http:// Apr 9, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Apr 9, 2025
@sbernauer sbernauer self-assigned this Apr 9, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 10, 2025
@sbernauer sbernauer added this pull request to the merge queue Apr 10, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Apr 10, 2025
Merged via the queue into main with commit 3c84831 Apr 10, 2025
27 checks passed
@sbernauer sbernauer deleted the chore/hbase-listener branch April 10, 2025 09:51
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
@Techassi Techassi mentioned this pull request Jun 2, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @NickLarsenNZ