-
-
Notifications
You must be signed in to change notification settings - Fork 3
fix: idempotent helm installations for demos/stacks and ignoring of existing jobs #386
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLarsenNZ
reviewed
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of suggestions
NickLarsenNZ
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would you mind updating the PR description and adding example output for the Job immutable fields? I was just curious what to expect.
This was
linked to
issues
Jun 10, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation for #312 and #333
Current procedure to upgrade a demo:
Example output of failed Job updates due to immutability:
Problem encountered during development when running
helm upgrade --install
onopensearch-dashboards
Thrown for
opensearch-dashboards
Helm Chart, because of opensearch-project/helm-charts#655Should be working due to setting
ChartSpec.Force = true
inrust/helm-sys/go-helm-wrapper/main.go
but does not.Update/Solution: Due to changes in Helm 3 and how the
--force
flag works (helm/helm#7082 (comment)), @NickLarsenNZ and me decided to switch from thehelm upgrade --install
to the strategy of uninstalling the old Helm Chart and installing the new one instead for an upgrade.Definition of Done Checklist