-
Notifications
You must be signed in to change notification settings - Fork 84
chore(dev-deps): update eslint
, prettier
, vitest
#333
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(dev-deps): update eslint
, prettier
, vitest
#333
Conversation
|
Nice! You also need to update the tutorialkit/packages/astro/scripts/build.js Lines 47 to 49 in afbc81f
This should be: define: {
'process.env.TUTORIALKIT_DEV': JSON.stringify(process.env.TUTORIALKIT_DEV ?? null),
'process.env.VITE_INSPECT': JSON.stringify(process.env.VITE_INSPECT ?? null),
}, Also wondering if we should call it |
Interesting way of using Vite's Another interesting note: this is what dead-code-elimination does to this line. I guess there's some edge case why it has to leave - process.env.TUTORIALKIT_DEV ? (await import('vite-plugin-inspect')).default() : null,
+ null ? (await null).default() : null https://unpkg.com/browse/@tutorialkit/astro@0.2.3/dist/index.js |
Oh that's an odd one! I've been trying to get esbuild to generate the same thing in their playground but failed. 😮 See this esbuild playground link. It always eliminate the |
Btw, this is not using We do this because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's merge this 🙌
@blitz/eslint-plugin
eslint-plugin-astro
vitest
vite-plugin-inspect