Make VPN ACL filter more precise #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
containsmatcher in the VPN EnvoyFilter more precise.The header value looks like
outbound|1194||vpn-seed-server.<technical-ID>.svc.cluster.local.We now include dots in the contains matcher as anchors, to always match the entire technical shoot ID.
Otherwise, if there is one cluster named
fooand one namedfoo-bar(in the same project),foowould effectively inherit the ACL offoo-bar.The PR also switches the inverse rule to
and_ids. Usingor_idswith a list ofnot_idmakes the policy always allow traffic if multiple shoots use the ACL extension and run behind the same ingress gateway.The more permanent solution to the problem is #43.